fix(middleware/combine): prevent c.req.routeIndex from being changed
#3663
+32
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paweł Dąbrowski <[email protected]>
The current implementation of `compose` does not use some elements of the received middleware, so they do not have to be passed on.
usualoma
changed the title
c.req.routeIndex from being changed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3663 +/- ##
=======================================
Coverage 91.69% 91.70%
=======================================
Files 159 159
Lines 10140 10145 +5
Branches 2877 2876 -1
=======================================
+ Hits 9298 9303 +5
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Ah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3657
As I also refactored the relevant parts, there are a lot of changes, but the key point is that c.req.routeIndex must not be changed’ in the following line.
https://github.com/honojs/hono/compare/main...usualoma:hono:fix/conbine-every-route-index?expand=1#diff-0127ebff640ea2834e4434792875961100daac21bcdaae2d033a6a59815da3bfR98
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code