Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark slow tests, update __eq__ methods, pin reqs #60

Merged
merged 32 commits into from
Feb 9, 2021

Conversation

brl0
Copy link
Collaborator

@brl0 brl0 commented Feb 6, 2021

Summary of changes:

  • Add --skip-slow option (slow tests are still run by default)
  • Mark various tests as slow based on run time as captured by pytest --durations=0
  • Pin numpy<1.20 on MacOS due to test failures
  • Add feature to Geometry class __eq__ method that if other object is a container, the equality method on the container is called, so now performing an equality check between a geometry object and a geometry array should return correct results, which should be a bool array, whereas previously it would simply return False because the objects were not the same immediate type.
  • Add feature to GeometryArray class __eq__ method to allow comparison of an individual element to all objects in the array, returning an array of bool.
  • Add NotImplementedError for __contains__ method.
  • Sort imports on modified files
  • Add some type hints to parquet functions

Let me know if there are any questions or concerns about any of these changes.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates! They look good apart from any concerns listed below.

@philippjfr and @jlstevens, are --skip-slow and --runslow the spellings we'd like for that option? I see we use pytest.mark.slow on nbsite but don't see any options defined there; looks like we just say to do pytest --pdb -m "not slow". Maybe at least call it --run-slow to make the hyphenation consistent?

setup.py Outdated Show resolved Hide resolved
spatialpandas/io/parquet.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@brl0
Copy link
Collaborator Author

brl0 commented Feb 8, 2021

In addition to the changes above, Dask has now been pinned on Mac due to incompatibilities with pyarrow>=2.
Also, I updated the change log for the next release.

@jbednar, thanks for your time reviewing and your input. Let me know if you have any additional questions or concerns.

I think this should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants