-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark slow tests, update __eq__
methods, pin reqs
#60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates! They look good apart from any concerns listed below.
@philippjfr and @jlstevens, are --skip-slow
and --runslow
the spellings we'd like for that option? I see we use pytest.mark.slow
on nbsite but don't see any options defined there; looks like we just say to do pytest --pdb -m "not slow"
. Maybe at least call it --run-slow
to make the hyphenation consistent?
In addition to the changes above, Dask has now been pinned on Mac due to incompatibilities with @jbednar, thanks for your time reviewing and your input. Let me know if you have any additional questions or concerns. I think this should be ready to merge. |
Summary of changes:
--skip-slow
option (slow tests are still run by default)pytest --durations=0
__eq__
method that if other object is a container, the equality method on the container is called, so now performing an equality check between a geometry object and a geometry array should return correct results, which should be a bool array, whereas previously it would simply return False because the objects were not the same immediate type.__eq__
method to allow comparison of an individual element to all objects in the array, returning an array of bool.__contains__
method.Let me know if there are any questions or concerns about any of these changes.