refactor: Change linting to Ruff

[hoxbro]

Aligning with our other repos.

[codecov]

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (71e8e47) to head (5453327).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
param/parameterized.py	71.42%	2 Missing ⚠️
param/serializer.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   87.26%   87.36%   +0.09%     
==========================================
  Files           9        9              
  Lines        4948     4939       -9     
==========================================
- Hits         4318     4315       -3     
+ Misses        630      624       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hoxbro]

I'm not entirely sure about this one.

[hoxbro]

Tested it. Needs to be an ImportError

Suggested change

	except ModuleNotFoundError:
	except ImportError:

[hoxbro]

Though even with ImportError it still does not work...

❯ python -c "import param"  # with ModuleNotFoundError
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/shh/projects/holoviz/repos/param/param/__init__.py", line 4, in <module>
    from .depends import depends  # noqa: api import
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/shh/projects/holoviz/repos/param/param/depends.py", line 9, in <module>
    from .parameterized import (
  File "/home/shh/projects/holoviz/repos/param/param/parameterized.py", line 28, in <module>
    from . import serializer
ImportError: cannot import name 'serializer' from partially initialized module 'param' (most likely due to a circular import) (/home/shh/projects/holoviz/repos/param/param/__init__.py)

param on  refactor_ruff [$✘] via 🅒 holoviz
❯ python -c "import param"  # with ImportError
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/shh/projects/holoviz/repos/param/param/__init__.py", line 4, in <module>
    from .depends import depends  # noqa: api import
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/shh/projects/holoviz/repos/param/param/depends.py", line 9, in <module>
    from .parameterized import (
  File "/home/shh/projects/holoviz/repos/param/param/parameterized.py", line 1027, in <module>
    class Parameter(_ParameterBase):
  File "/home/shh/projects/holoviz/repos/param/param/parameterized.py", line 1170, in Parameter
    _serializers = {'json': serializer.JSONSerialization}
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'JSONSerialization'

[hoxbro]

Should we remove the try/except here? Nobody has complained about it, and that line was changed in June of 2021.

[maximlt]

From what I've heard, and IIRC, Param was designed to be used super easily by simply copy-pasting one or two files in a project, which works as it has no external dependency. It's likely it made people's lives easier 10/15 years ago, these days we expect users to pip/conda install their dependencies and in the vast majority of cases it works fine.
So I think that yes we should remove the try/except and generally lift the assumption that you can copy-paste some modules and it works, if it's baked in other places. I also wouldn't be surprised if one day we added some dependencies to Param (e.g. typing-extensions if we finally do some typing work in Param).

cc @philippjfr @jbednar @jlstevens

[jlstevens]

@maximlt is right in that param was originally designed to be easily vendored-in to any codebase. I personally have no strong feelings about this: while being easy to avoid an extra dependencies can be nice, it is also true that the majority of users will be using a package manager.

[hoxbro]

To be sure, the question right now is not about adding an extra dependency but about removing the try/except around the serializer import, which has been broken since 2021.

[jlstevens]

Right, was just confirming what Maxime said and given this import has been broken so long, the issue is rather moot!

[jbednar]

I agree that it is no longer important to be able to paste in the two main Param files directly into a project. Param was first written before conda and even before pip, and adding a dependency was much more of a big issue in those days. Happy to see this and any similar try/excepts removed, when they depend only on files in param itself.