Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated reactive docs #841

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Updated reactive docs #841

merged 2 commits into from
Sep 24, 2023

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Sep 24, 2023

I think this will take several iterations, but I've tried to tease out a better motivating introductory section without making too many changes. @philippjfr , please review and see if it's going in a direction you're happy with; feel free to close if not.

I suspect that it's still trying to be too ambitious, and that we shouldn't immediately dive in trying to change the dataframe itself, because that's an advanced topic using bind, while if we simply make the dataframe and some values reactive, I think the user will be able to see how it works much better. If I get a chance I'll try that out, but wanted you to have this before I went to bed in case you work on it tomorrow.

I also think the example still isn't that great without widgets. I do like what it does for the loop I put in there now, which substitutes for having a slider; I think there's something we can do with that. E.g. maybe some sort of animation?

Plus the material after the "Why?" section is still starting with Parameters, while I think it would be better to focus on what a reactive expression is and how it behaves, and then get into Parameters only as one way of getting such an expression, as well as an implementation detail behind them. Anyway, not urgent, just handing this over in case it's useful!

@philippjfr
Copy link
Member

Thanks, I honestly just wanted to get something in before the RC release. This may well still be too ambitious but it's definitely an improvement.

@jbednar jbednar added the WIP label Sep 24, 2023
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive improvement, so I'll merge. I suspect we'll have to iterate a bit more but I'd like to be unblocked on other tasks.

@philippjfr philippjfr merged commit 6a20bf1 into main Sep 24, 2023
10 checks passed
@philippjfr philippjfr deleted the rxdocs branch September 24, 2023 16:06
philippjfr pushed a commit that referenced this pull request Sep 24, 2023
* Updated reactive docs

* Simplified flow of first example
@jbednar jbednar restored the rxdocs branch September 24, 2023 16:40
@maximlt maximlt deleted the rxdocs branch October 8, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants