Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will take several iterations, but I've tried to tease out a better motivating introductory section without making too many changes. @philippjfr , please review and see if it's going in a direction you're happy with; feel free to close if not.
I suspect that it's still trying to be too ambitious, and that we shouldn't immediately dive in trying to change the dataframe itself, because that's an advanced topic using
bind
, while if we simply make the dataframe and some values reactive, I think the user will be able to see how it works much better. If I get a chance I'll try that out, but wanted you to have this before I went to bed in case you work on it tomorrow.I also think the example still isn't that great without widgets. I do like what it does for the loop I put in there now, which substitutes for having a slider; I think there's something we can do with that. E.g. maybe some sort of animation?
Plus the material after the "Why?" section is still starting with Parameters, while I think it would be better to focus on what a reactive expression is and how it behaves, and then get into Parameters only as one way of getting such an expression, as well as an implementation detail behind them. Anyway, not urgent, just handing this over in case it's useful!