Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiple annotators in annotation table #31

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 21, 2023

There no longer seems to be a need when having AnnotationTable associated with multiple annotators.

This will change the behavior so that an Annotator always has one connector and one annotation table associated with it. AnnotationTable has no knowledge about the annotator. Following this diagram:

1

@@ -433,10 +414,3 @@ def load_annotation_table(self, conn: Connector, fields: list[str], spec: SpecDi

self._update_index()
self.clear_edits()

def add_schema_to_conn(self, conn: Connector) -> None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to connector

@hoxbro hoxbro force-pushed the remove_multiple_annotators_in_table branch from 37e9a75 to b65d2e5 Compare September 29, 2023 10:57
@hoxbro hoxbro merged commit 53239a0 into main Oct 3, 2023
11 checks passed
@hoxbro hoxbro deleted the remove_multiple_annotators_in_table branch October 3, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant