Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Dask 2024.11 #766

Merged
merged 7 commits into from
Nov 11, 2024
Merged

compat: Dask 2024.11 #766

merged 7 commits into from
Nov 11, 2024

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Nov 9, 2024

Hopefully?

ERROR geoviews/tests/test_projection.py - FutureWarning: The legacy Dask DataFrame implementation is deprecated and will be removed in a future version. Set the configuration option dataframe.query-planning to True or None to enable the new Dask Dataframe implementation and silence this warning.

Taken from https://github.com/holoviz/holoviews/pull/6149/files

@hoxbro
Copy link
Member

hoxbro commented Nov 9, 2024

It is the new dask release, try to pin 2024.10 for now. I will look into it soon. Or filter warning directly in pyproject.toml.

@hoxbro
Copy link
Member

hoxbro commented Nov 9, 2024

FYI #763 (if you haven't seen it)

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.40%. Comparing base (79cde9d) to head (6fec094).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #766       +/-   ##
===========================================
+ Coverage   15.48%   67.40%   +51.91%     
===========================================
  Files          41       45        +4     
  Lines        4488     4669      +181     
===========================================
+ Hits          695     3147     +2452     
+ Misses       3793     1522     -2271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 requested a review from hoxbro November 11, 2024 02:52
@hoxbro hoxbro changed the title Fix CI compat: Dask 2024.11 Nov 11, 2024
geoviews/tests/conftest.py Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but LGTM.

@ahuang11 ahuang11 merged commit da8719e into main Nov 11, 2024
13 checks passed
@ahuang11 ahuang11 deleted the suppress_dask_query_planning branch November 11, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants