Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thumbnails automatically #32

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Oct 7, 2023

DON'T MERGE YET. MORE WORK TO BE DONE!

Depends on #12. Please review that one first.

You can generate the thumbnails via

SCREENSHOT=true hatch run pytest -m ui
cp tests/ui/screenshots/* docs/assets/thumbnails/

I don't think the screenshots are yet meaningful enough. We should refactor the examples to make it very easy to understand what they are about from a screenshot. Alternatively we could agree to use manual screenshots?

What do you think @ahuang11 ?

@MarcSkovMadsen MarcSkovMadsen changed the title Update thumbnails Update thumbnails automatically Oct 7, 2023
@ahuang11
Copy link
Collaborator

ahuang11 commented Oct 8, 2023

I agree with you that they're not really helpful at this moment.

I think to make them useful, we should somehow detect that it's getting a screenshot and programmatically send a message to trigger a response and then grab a screenshot after waiting 5s.

Also, we should add titles to each of the ChatInterface.

Or ideally, we manually create GIFs of them which is much more intriguing than screenshots.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 9, 2023

Yes. My thoughts are

  • We could use playwright to interact with the live application before taking the screenshot.
  • In addition to taking a screenshot it could also record a video.
  • We could the show the video instead of the image when a user hover over the image ?
  • In addition we could autogenerate links in the index.md to quickly share on social media with text and gif.

@MarcSkovMadsen
Copy link
Collaborator Author

One issue currently is that Playwright does not show the emojis when taking screenshots

image

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 9, 2023

I got the automation concept for screenshot and video working. The below is automatically recorded for echo.py.

3499ef8039af2b1a223a0f07c600bee0.webm

test-finished-1

As you can see the emojis are shown. It works when I run on my laptop in --headed mode.

@ahuang11 ahuang11 merged commit 841af06 into holoviz-topics:main Oct 9, 2023
1 of 2 checks passed
@ahuang11
Copy link
Collaborator

ahuang11 commented Oct 9, 2023

Thanks; that's quite impressive that this is doable! I'll fix the tests and add the videos in another branch.

@MarcSkovMadsen MarcSkovMadsen mentioned this pull request Oct 9, 2023
11 tasks
@MarcSkovMadsen
Copy link
Collaborator Author

We should coordinate a bit @ahuang11 . I'm implementing the playwright/ video code here #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants