Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t_sne_roots project #286

Closed
wants to merge 5 commits into from
Closed

Add t_sne_roots project #286

wants to merge 5 commits into from

Conversation

jlstevens
Copy link
Contributor

Adds an interactive dimensionality reduction dashboard example with instant inspection hover.

UMAP_hover_dashboard

Wondering if we should leave the training data on hugging face or grab our own copy...

@jlstevens jlstevens added the wip Work in progress; do not merge label Jul 28, 2023
@droumis
Copy link
Contributor

droumis commented Jul 28, 2023

it would be amazing if the hover tooltip is hidden or suppressed when the cursor is not near a real data point; that would make this inspection much more like what users experience for non-image plots.

I'm guessing this would require a custom hovertool and customjs callback that sets the visibility of the tooltip based on the data value

@github-actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt
Copy link
Contributor

maximlt commented Jul 28, 2023

Oh I forgot about that bot, happy that it worked: https://holoviz-dev.github.io/examples/t_sne_roots/t_sne_roots.html

@jlstevens
Copy link
Contributor Author

@droumis That is an excellent observation! Ideally this is something we could push to the Bokeh level...

@MarcSkovMadsen
Copy link
Collaborator

Would it be an idea to make the plot responsive? (Yes 😉)

@jbednar
Copy link
Contributor

jbednar commented Jul 28, 2023

Would it be an idea to make the plot responsive?

Yes 😉. Jean-Luc indicated that the tricky aspect of that was, well, the aspect, in that the plot gets squished. But I argue that the plot should fill the template fully, but with black on either side initially and showing the complete data when zooming in. Using only the largest square plot is fine for a static plot, but as soon as one zooms in, it feels very constraining to be locked into that tiny box.

@jbednar
Copy link
Contributor

jbednar commented Jul 28, 2023

Wondering if we should leave the training data on hugging face or grab our own copy...

Definitely grab our own copy.

Copy link
Contributor

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Looking forward to seeing that second pass eliminated. Can you maybe also open an issue that will stay open once this is merged, asking you to update this project once a given task list is addressed, where each item in the task list is an open Bokeh or HoloViews issue that needs to be fixed and released before this example can be updated with one pass? If new issues are needed on either of those repos, please do open those as well.

t_sne_roots/t_sne_roots.ipynb Show resolved Hide resolved
"outputs": [],
"source": [
"points = hv.Points(df, ['x','y'], ['language'])\n",
"op = datashade(points, color_key=cc.glasbey_light,\n",
Copy link
Contributor

@jbednar jbednar Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many distinct languages are there, and are they sorted by popularity? At a glance it looks like 20 or so main categories, and if so Category20 might give more vibrant colors, or maybe glasbey_category10 if there are 20 main ones but then lots of rare categories. Or Category20 + glasbey_light, in that latter case.

@jlstevens
Copy link
Contributor Author

Superseded by #337 which introduces client side color mixing.

I'll address the question about the potential colormaps there.

@jlstevens jlstevens closed this Dec 6, 2023
@maximlt maximlt deleted the t_sne_roots branch October 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress; do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants