Performance #517 #526
Open
Performance #517 #526
+43
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamtschatka
commented
Oct 12, 2024
| export function getAssetUrl(assetId: string) { | ||
| return `/api/assets/${assetId}`; | ||
| export function getAssetUrl(assetId: string, preview?: boolean) { | ||
| return `/api/assets/${assetId}${preview ? "?preview" : ""}`; |
There was a problem hiding this comment.
as for why i am using the querystring "?preview" instead of "?preview=true" (or something similar):
The element would then URL encode the "=" sign, which breaks the URL for some reason and then route.ts will not be called anymore.
made sure the image size is based on the bookmark containers width and not on the full page width
…uce the filesize significantly if the preview is a full page screenshot
kamtschatka
force-pushed
the
fixed-loaded-image-size
branch
from
a9e1da7
to
c337fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made sure the image size is based on the bookmark containers width and not on the full page width