Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18875 Stop using Array.newInstance in org.hibernate.internal.util.collections.StandardStack #9309

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Nov 22, 2024

Sharing as a draft as I couldn't test the impact on Quarkus native-images yet.

@sebersole
Copy link
Member

The changes look reasonable to me, but I'll wait to integrate until we see the impact in Quarkus since this is largely about/from Quarkus.

@Sanne Sanne marked this pull request as ready for review November 27, 2024 09:25
@Sanne
Copy link
Member Author

Sanne commented Nov 27, 2024

Ok, this seems to work in native.
As mentioned on zulip:

ok - it seems to all work as we wanted, by experimenting with the main branch on Quarkus and using a backport of the patches from ORM7 to 6.6:

  • removing the workarounds AND the GraalVM registrations from ORM, but not applying the StandardStack improvements it fails in native
  • then adding only the StandardStack fix, it works again

So, I couldn't verify it on the ORM7 branch but it looks like sound

rebased

@Sanne Sanne changed the title HHH-18875 HHH-18875 Stop using Array.newInstance in org.hibernate.internal.util.collections.StandardStack Nov 27, 2024
@hibernate hibernate deleted a comment from hibernate-github-bot bot Nov 27, 2024
@Sanne Sanne merged commit 39f5946 into hibernate:main Nov 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants