Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crate num-bigint in miller rabin #6

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

hesampakdaman
Copy link
Owner

@hesampakdaman hesampakdaman commented Apr 5, 2024

Changes

In this PR we will change from depending on u128 to BigUint. We will continue to do so until we only depend on this crate. Note that this change will make us tightly coupled to this crate (we provide no interface in between num_bigint and our program).

  • Switch from u128 to BigUint from num_bigint crate in miller_rabin.
  • Use references where applicable, esp. from the entrypoint to miller_rabin and downstream. Later we will change the trait PrimalityTest to take &BigUint instead of u128.

@hesampakdaman hesampakdaman force-pushed the miller-rabin-num-bigint branch 5 times, most recently from 8b9c51d to 438e61e Compare April 6, 2024 11:54
@hesampakdaman hesampakdaman merged commit c366f3b into main Apr 6, 2024
1 check passed
@hesampakdaman hesampakdaman deleted the miller-rabin-num-bigint branch April 6, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant