Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update moratorium check and change management workflows #3107

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: update moratorium check and change management workflows #3107

wants to merge 6 commits into from

Conversation

k80bowman
Copy link
Contributor

@k80bowman k80bowman commented Nov 20, 2024 •
edited
Loading

This PR updates our new change management workflows in a couple of ways:

  • It moves the check-for-moratorium and change-management workflows to their own github workflow files
    • This will make testing them easier and will enable to us to run them independently in case of a failure
  • It updates the create-cli-release and start-gh-release workflows so that they require the moratorium check for all stable releases.

This PR also includes a small change that will hopefully fix the devcenter-doc-update workflow

@k80bowman k80bowman requested a review from a team as a code owner November 20, 2024 22:08
@k80bowman k80bowman changed the title chore: update change management workflows chore: update moratorium check and change management workflows Nov 20, 2024
@k80bowman k80bowman mentioned this pull request Nov 20, 2024
Closed
eablack
eablack approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small question/suggestion.

.github/workflows/create-cli-release.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars mars mars left review comments

@eablack eablack eablack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k80bowman @mars @eablack