-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new endpoints for api #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exciting changes await! We added some very important new endpoints in this PR that still were missing. Here is what is now available:
Statistics
Statistics for the entire galaxy or a specific planet, this includes number of kills, friendly fire kills etc. Please Note that not every planet has statistics, this is because there may not have been fought a battle on it yet.
/api/statistics
: List all available statistics./api/statistics/:id
: Get a specific statistic by id./api/statistics/galaxy
: Get the galaxy wide statistics./api/planets/:id/statistics
: Get statistics for a planet.Reports
You can find reports by pressing R2 or the PC equivalent while in your ship. Contain bits of story and lore based on the players actions and performance in the war.
/api/reports
: List all available reports./api/reports/:id
: Get a specific report by id.Assignments
Assignments are Major Orders that are very important to the war progress. It is possible that a given time there is no Major Order and the endpoint will return an empty array.
/api/assignments
: List all available assignments./api/assignments/:id
: Get a specific assignment by id./api/assignments/:id/rewards
: Get the rewards for a specific assignment.Shout out to all developers over at Helldivers 2 Community that have reverse engineered the required endpoints for this addition to our API.
Type of change
How Has This Been Tested?
Added test new files for all endpoints
__tests__/statistics.test.ts
__tests__/reports.test.ts
__tests__/assignments.test.ts
__tests__/planets.test.ts
Test Configuration
Checklist