Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible fix for cosign error #20

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix: possible fix for cosign error #20

merged 2 commits into from
Mar 26, 2024

Conversation

fabio-nettis
Copy link
Member

Description

This PR tries to fix an issue with cosign that only appears if the image should be released e.g when pushing to main. Interestingly we also struggle with #3 here, but there is no solution for that for now.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fabio-nettis fabio-nettis added the bug Something isn't working label Mar 26, 2024
@fabio-nettis fabio-nettis merged commit fb9df97 into main Mar 26, 2024
4 checks passed
@fabio-nettis fabio-nettis deleted the fix/docker-image branch March 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant