Add "hed-validator" to run validation on BIDS dataset #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other hed_ scripts I prefixed this as hed- to be more consistent with conventions like git-COMMAND, bids-validator, etc. I have not yet had luck to get errors to see how those would look and if would work to serialize into json. hed-examples are all clean. Sample dataset I had crashes validator (separate issue to follow).
This was referenced Oct 3, 2024
VisLab
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I'm going to go ahead and merge this. This does basic validation of events. CLI validation is also available through the remodeling interface, but we definitely need this standalone validation. Thx..... We'll update it to include a more comprehensive list of BidsDataset parameters and do some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other hed_ scripts I prefixed this as hed- to be more consistent with conventions like git-COMMAND, bids-validator, etc.
I have not yet had luck to get errors to see how those would look and if would work to serialize into json. hed-examples are all clean. Sample dataset I had crashes validator (separate issue to follow).
edit: based on https://github.com/hed-standard/hed-examples/blob/main/src/jupyter_notebooks/bids/validate_bids_dataset.ipynb
ref: partially addresses hed-standard/hed-examples#405