Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: add klayout #268

Merged
merged 1 commit into from
Dec 23, 2022
Merged

misc: add klayout #268

merged 1 commit into from
Dec 23, 2022

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Dec 21, 2022 •
edited
Loading

Based on @klayoutmatthias's fork of conda-forge/staged-recipes#20396.

Wanted to just build the CLI to aligned with #250 and #193 but couldn't find a build option to disable QT while still keeping klayout_main.

Fixes #175

mithro
mithro approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

misc/klayout/force-python-dynamic-link.patch
@@ -0,0 +1,53 @@
diff --git a/build.sh b/build.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log a github issue to get this upstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect @klayoutmatthias link statically intentionally.

misc/klayout/build.sh
Linux*) OS=Linux;;
*) OS="${UNAME_OUT}"
echo "Unknown OS: ${OS}"
exit;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #269 since this seems more widespread.

@proppy
Copy link
Contributor Author

proppy commented Dec 21, 2022

LGTM.

Let's not merge before we get the CI passing.

@proppy
Copy link
Contributor Author

proppy commented Dec 21, 2022

@mithro yay it's green! https://github.com/hdl/conda-eda/actions/runs/3751563916/jobs/6372696825 \o/

@mithro
Copy link
Member

mithro commented Dec 21, 2022

Looks like the CI is still generally broken however?

@proppy
Copy link
Contributor Author

proppy commented Dec 21, 2022

@mithro in my experience the CI is generally flaky for some of the f4pga packages (vtr, yosys-osx) to but I don't see any issues in that runs for the silicon toolchain packages.

@mithro
Copy link
Member

mithro commented Dec 21, 2022

Merge away then?

@proppy
Copy link
Contributor Author

proppy commented Dec 21, 2022

I suspect @ajelinski will want us to audit the warnings and squash commits first!

@proppy
Copy link
Contributor Author

proppy commented Dec 22, 2022 •
edited
Loading

Identified 4 cluster of warnings:

  • WARNING rpath /home/runner/work/conda-eda/conda-eda/workdir/conda-env/conda-bld/klayout_1671649256384/_build_env/lib is outside prefix which I believe are due to cdt.

  • WARNING Failed to get_static_lib_exports which according to can safely be ignored pnr: add openroad #165 (comment)

  • WARNING (klayout,bin/strmclip): Needed DSO lib/libQt5Core.so.5 found in ['qt'] but ['qt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely) which need fixing.

  • WARNING (klayout): run-exports library package pkgs/main::icu-58.2-he6710b0_3 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to build/ignore_run_exports) which need fixing.

@proppy
Copy link
Contributor Author

proppy commented Dec 22, 2022

A few remaining warnings from https://github.com/hdl/conda-eda/actions/runs/3758645638/jobs/6387239942

  65630:2022-12-22T15:28:51.4619538Z WARNING (klayout,lib/libklayout_tl.so.0.28.1): Needed DSO lib/libpng16.so.16 found in ['libpng']
  65631:2022-12-22T15:28:51.4620164Z WARNING (klayout,lib/libklayout_tl.so.0.28.1): .. but ['libpng'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  65632:2022-12-22T15:28:51.4620717Z WARNING (klayout,lib/libklayout_tl.so.0.28.1): Needed DSO lib/libexpat.so.1 found in ['expat']

those are cdt so I don't think they are required.

  65633:2022-12-22T15:28:51.4621305Z WARNING (klayout,lib/libklayout_tl.so.0.28.1): .. but ['expat'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  65634:2022-12-22T15:28:51.4621856Z WARNING (klayout,lib/libklayout_tl.so.0.28.1): Needed DSO lib/libz.so.1 found in ['zlib']
  65635:2022-12-22T15:28:51.4622450Z WARNING (klayout,lib/libklayout_tl.so.0.28.1): .. but ['zlib'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
  65717:2022-12-22T15:28:51.4684921Z WARNING

This probably need to be added to host/run explicitly.

(klayout,lib/klayout/lay_plugins/liblefdef_ui.so.0.28.1): $RPATH/liblefdef.so.0 not found in packages, sysroot(s) nor the missing_dso_whitelist.
  66035:2022-12-22T15:28:51.4879561Z WARNING (klayout,lib/klayout/lay_plugins/libnet_tracer_ui.so.0.28.1): $RPATH/libnet_tracer.so.0 not found in packages, sysroot(s) nor the missing_dso_whitelist.
  66063:2022-12-22T15:28:51.4896117Z WARNING (klayout,lib/klayout/lay_plugins/libpcb_ui.so.0.28.1): $RPATH/libpcb.so.0 not found in packages, sysroot(s) nor the missing_dso_whitelist.

assuming those are unused?

@proppy
Copy link
Contributor Author

proppy commented Dec 23, 2022

This probably need to be added to host/run explicitly.

Done.

@proppy
Copy link
Contributor Author

proppy commented Dec 23, 2022

and rebased.

@proppy
Copy link
Contributor Author

proppy commented Dec 23, 2022

Merging since the build is green and remaining warnings were addressed per #268 (comment)

@proppy proppy merged commit c8cc9a7 into hdl:master Dec 23, 2022
@basnijholt basnijholt mentioned this pull request Mar 30, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add klayout package
2 participants
@proppy @mithro