-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toolchain: add symbiflow-toolchain package #145
base: master
Are you sure you want to change the base?
Conversation
|
||
mkdir -p $PREFIX | ||
|
||
curl -s https://storage.googleapis.com/symbiflow-arch-defs-gha/symbiflow-toolchain-latest | xargs wget -qO- | tar -xJC $PREFIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need to make sure that there is a connection between these assets and the symbiflow-arch-defs git revision and not use the random latest version....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this needs to download the results which match the git revision used to generate the package metadata. That info should be available in the shell environment somewhere...
As we've been discussing this internally, our current approach is to:
This PR is a stub we begin with, based on the work we started ~1 year ago |
Is there a simple way to go from symbiflow-arch-defs git revision number to the build CI output? If so, you could use that process so that the contents are determined by the symbiflow-arch-defs git revision the package is built with? |
Actually the git revision number is present within the link contained in For instance, the current latest link is the following:
Where The above link also contains the build date, so we may probably extract that as well from there. |
Signed-off-by: Alessandro Comodi <[email protected]>
879e831
to
344ca3d
Compare
That is the wrong way around. You want to go from git revision ID to a build result (not from a build result to a git revision ID). |
Signed-off-by: Alessandro Comodi [email protected]
This supersedes #48, and adds the symbiflow toolchain package