Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser module uses hand-written parser (much faster). Get rid of parsec #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Paczesiowa
Copy link

this makes prepare function much faster (and much less garbagy). I've tested the new implementation with the old one using a few runs of 10^6 testcases generated with quickcheck

@zenzike
Copy link
Member

zenzike commented Dec 13, 2012

I'm a little nervous about merging this one in: it may be much faster (by how much?), but it doesn't seem nearly as maintainable to me. If the concern is that parsec is too slow, have you looked at using attoparsec to solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants