-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LBZ notations. #227
Conversation
Diffed against mapping reported to DigiBib (2020-12-28, DOX-917). Additional notations not removed: - 136 Landeskunde Region Trier (6a2c4c4) - 137 Landeskunde Rheinhessen (6a2c4c4) - 139 Belegexemplare Rheinland-Pfalz (6a2c4c4) - 146 Pflichtexemplar Region Trier (6a2c4c4) - 147 Pflichtexemplar Rheinhessen (6a2c4c4) - 160 Kinder-/Jugendliteratur (e3ec4fc) - 161 Kinder-/Jugendsachbuch (e3ec4fc)
Interestingly these are not part of: https://lbz.rlp.de/fileadmin/lbz/LBZ-Bibliotheken/Anmelden-und-Ausleihen/LBZ-Notationenuebersicht.pdf Also see hbz/lobid-resources#2057 |
@blackwinter , it definitely makes sense to move to the SKOS file(s). I think we discussed with LBZ that they would be using these as single source of truth. However, they are not (yet) perfect, see e.g. hbz/lobid-resources#2057 which will probably result in some missing notations being added. With regard to the review of this PR, the final say should have LBZ people who already have been working in this repo. |
The changes this PR ewould bring to the vocab can also be viewed with SkoHub Vocabs at https://skohub.io/hbz/lobid-vocabs/heads/wip-updateLBZNotations/w3id.org/lobid/rpb2.html |
Sure, just let me know how you want to proceed. Should I split this pull request or continue as it is? Who would be the reviewers to be assigned? |
As planned for some time, we have now moved the LBZ vocabs to a new repo at https://github.com/hbz/lbz-vocabs. @blackwinter I have already cherry-picked your fix from 0bcfd58, see hbz/lbz-vocabs@0d902e6. It would be good if you could open another PR over at lbz-vocabs for the other commit. |
Moved to hbz/lbz-vocabs#3. |
hbz/lbz-vocabs#3; hbz/lbz-vocabs#6)" This reverts commit 1038611. Results in `java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "elasticsearch-rest-client-0-thread-[...]"`.
We're considering switching our LBZ notation mapping in Limetrans to the SKOS one maintained here. But there were some differences, mainly in the labels. These should probably be clarified.
Diffed against mapping reported to DigiBib (2020-12-28, DOX-917).
Additional notations not removed:
The first commit is unrelated, but came up during editing the file. May be fixed separately.