-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to Stylelint v15 #243
base: main
Are you sure you want to change the base?
Conversation
π¦ Changeset detectedLatest commit: 06af1d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
π¦ Canary Packages PublishedLatest commit: 06af1d3 |
"stylelint-config-css-modules": "^4.2.0", | ||
"stylelint-config-standard": "^34.0.0", | ||
"stylelint-order": "^6.0.3", | ||
"stylelint-use-nesting": "^4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I'm following, what is the explanation for removal of
stylelint-config-prettier
stylelint-media-use-custom-media
stylelint-value-no-unknown-custom-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first one isn't necessary anymore, and the latter two are not compatible with v15. I figured we can probably live without those two for now and add them back when/if they update for v15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! Left a non-blocking question
@thiskevinwang looks like we'd need to disable a good chunk of rules to prevent auto-fixes on www.
A few rules are dumb imo (such as |
ποΈ Asana Task
Description
This PR updates Stylelint in
platform-cli
to the latest version to ensure compatibility with the latest versions of CSS.PR Checklist π