Add HTTP variant of Discover #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
radeksimko
reviewed
Jan 23, 2023
There was a problem hiding this comment.
👋🏻 @taiidani
Would it make sense to keep the API footprint small and "hide" this as a field e.g. UseInsecureHTTP bool under the Disco struct?
|
@radeksimko I actually recently confirmed an alternate solution that works for I haven't yet confirmed if this works for terraform-provider-tfe's use of svchost. Would you happen to know if it will? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding the ability to perform discovery against HTTP-based endpoints, enabling Local Development-based use cases for users such as those developing upon TFC.