Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_fs deprecation message on clusters newer than 1.28 #2418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Feb 8, 2024

Description

Fixes #2406

Usually we would mark any fields as deprecated with Deprecated along with a summary, however this isn't the best UX since any use of the deprecated field will cause a message to pop up, ideally this would only pop up on clusters newer than 1.28

Currently looking for how to make this possible

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner February 8, 2024 07:03
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If conditionality is required then best bet is to use a diagnostic supported Create/Update func and add warnings there. Might involve moving the whole Create or Update func to that but it should be no risk.

@BBBmau
Copy link
Contributor Author

BBBmau commented Feb 13, 2024

@appilon this was something that did come to mind but wasn't sure if it was a valid reason to move the whole Create/Update functions in order to get it working. I'll try it out and see what happens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate ceph_fs in persistent_volume
2 participants