Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for config_data #2195

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added support for config_data #2195

wants to merge 7 commits into from

Conversation

eduanb
Copy link

@eduanb eduanb commented Jul 18, 2023

Description

This PR allows you to send in the raw kubeconfig data without first creating a temp file.
Closes #1735

Note: I have very little Go experience, so please let me know if I need to change things. Would greatly appreciate it if someone could help with writing a test for this.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

FEATURE:
Add `config_data` property to specify the raw contents of a kube config
...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@eduanb eduanb requested a review from a team as a code owner July 18, 2023 20:10
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I'll be taking a look at this PR in the coming weeks, could you provide a test for this new field in the provider? or a terraform config that will save the time to review this PR thoroughly. Thank you in advance 👍🏼

@BBBmau
Copy link
Contributor

BBBmau commented Apr 24, 2024

@eduanb pinging to be able to get a test config for this.

Optional: true,
Sensitive: true,
DefaultFunc: schema.EnvDefaultFunc("KUBE_CONFIG_DATA", nil),
Description: "Raw kube config data for the kubernetes provider",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially when running this locally the provider would fail to build due to the descriptions not being the same between kubernetes/provider.go and manifest/provider_config.go

After making some adjustments as well removing ConflictsWith, I was able to produce working applies where i used the local provider to test the new field.

A test would be great to include, we'll also want to include this in the kubernetes documentation and finally a changlog generation. Let me know if help is needed to get this PR in a mergable state.

@BBBmau BBBmau self-assigned this Aug 13, 2024
@BBBmau BBBmau added this to the v2.23.0 milestone Aug 14, 2024
@BBBmau BBBmau modified the milestones: v2.33.0, v2.34.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kubeconfig file data instead of path only
3 participants