-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hvs pg rotating secret #1130
base: main
Are you sure you want to change the base?
hvs pg rotating secret #1130
Conversation
|
||
// Inner API-compatible models derived from the Terraform fields | ||
capabilities []*secretmodels.Secrets20231128Capability `tfsdk:"-"` | ||
staticCredentialDetails *secretmodels.Secrets20231128PostgresStaticCredentialsRequest `tfsdk:"-"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to add a gateway pool ID here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we introduce that separately (in a diff PR) or here?
are (should) gateways be added to the tf provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd opt for here since a postgres integration is not particularly useful without a gateway
…rovider-hcp into dh/hvs-pg-rotating
…to dh/hvs-pg-rotating
…to dh/hvs-pg-rotating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
postgresql vs postgres
-
no test?
Import is supported using the following syntax: | ||
|
||
```shell | ||
terraform import hcp_vault_secrets_integration_postgres.example my-postgres-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify my-postgres-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,57 @@ | |||
--- | |||
# generated by https://github.com/hashicorp/terraform-plugin-docs | |||
page_title: "hcp_vault_secrets_integration_postgres Resource - terraform-provider-hcp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be named postgresql?
|
||
### Optional | ||
|
||
- `project_id` (String) HCP project ID that owns the HCP Vault Secrets integration. Inferred from the provider configuration if omitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where this can be found?
|
||
Required: | ||
|
||
- `connection_string` (String, Sensitive) Connection string (DSN) for the Postgres database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where this can be found?
|
||
### Required | ||
|
||
- `capabilities` (Set of String) Capabilities enabled for the integration. See the Vault Secrets documentation for the list of supported capabilities per provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find the matching documentation
Description: "Connection string (DSN) for the Postgres database.", | ||
Required: true, | ||
Sensitive: true, | ||
Validators: nil, // TODO: add validation for the URL format? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix or remove TODO
add new postgres integration resource and add postgres rotating secret
HV-1704
HV-1707
🛠️ Description
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...