container: fix missing updates for google_container_cluster.node_config subfields
#8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig` subfields (#12014) [upstream:34dd74df5c9291629ca1b215636294ca56aaa6ee] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-34dd74df5c9291629ca1b215636294ca56aaa6ee
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where many subfields of
node_configin a cluster (which affects the default node-pool "default-pool" whenremove_default_node_poolis not set tofalse) don't support updates properly, and also allows 3 subfields which had been previously set to force recreation of the default node pool (because updates were non-functional) to be updated in-place.Some acceptance tests are added, and some existing tests have been adjusted to confirm that the behavior is the same between
google_container_cluster.node_configandgoogle_container_node_pool.node_config.Fixes hashicorp/terraform-provider-google#19225
Fixes hashicorp/terraform-provider-google#18208
Fixes hashicorp/terraform-provider-google#16054
Fixes hashicorp/terraform-provider-google#13872
Possible fix for hashicorp/terraform-provider-google#17522 roaks3: This helps but I don't think it's a fix per se
Partial / possible fix for hashicorp/terraform-provider-google#12966 roaks3: Agreed, might fix, but we shouldn't close it yet
Followup to #11826 where the code used by the regular node pool update code was broken out.
Release Note Template for Downstream PRs (will be copied)
References
See above for some other issues that I believe may be fully or partially resolved by this.
b/361634104
Derived from GoogleCloudPlatform/magic-modules#12014