fix: #479 allow nested repos for gitlab.com #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tvizor
force-pushed
the
allow-nested-repos-gitlab-com-allow-subpath-query
branch
2 times, most recently
from
b1ac42c
to
a76aa0f
Compare
tvizor
force-pushed
the
allow-nested-repos-gitlab-com-allow-subpath-query
branch
from
a76aa0f
to
5515e0a
Compare
tvizor
changed the title
2 tasks
|
Could we get someone to review this change, please? |
…-subpath-query fix: hashicorp#479 allow nested repos for gitlab.com
rebase or main repo
tvizor
force-pushed
the
allow-nested-repos-gitlab-com-allow-subpath-query
branch
from
b92f938
to
83ccf98
Compare
|
I am not sure why I am only now seeing this notification in GitHub, but I will raise this in triage. I find this comment interesting, gruntwork-io/terragrunt#3031 (comment), will see what is underneath that difference. To set expectations, there is a strong headwind to getting PRs reviewed and merged into this repo due to multiple products using it and an unwillingness to inadvertently add new bugs. In any case, thanks for the submission! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #479
As per GitLab documentation, repositories can be nested under projects and subgroups: https://docs.gitlab.com/ee/user/group/subgroups/
MR is to remove the limit of 3 components of the path (gitlab.com/username/repo) and allow referencing paths to directories inside the repo.
Parse must be performed on the whole URL before evaluating and adding the .git suffix to the repo name to keep the ref query in its original format (?ref=master vs %3Fref=master if parsed as a part of the path).