Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 bump fast-sourcemap-concat version #2575

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

cameronperera
Copy link
Collaborator

Description

bump fast-sourcemap-concat version to remove lodash.template from our yarn.lock again. Not sure how it was added back but this should fix that. It is still in our electron/yarn.lock but that also has the patch in place.

Test Release

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Nov 15, 2024
@cameronperera cameronperera requested a review from a team as a code owner November 15, 2024 23:00
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:08pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:08pm

@calcaide
Copy link
Collaborator

@cameronperera
JFYI: About the lodash in desktop, it will be deleted within this PR, which is blocked because the pipeline is broken. Hopefully, soon, we can get a path to follow on the pipeline issues and the mentioned PR can get in, therefore no more need for lodash patch in our codebase 😃

Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up! 🙌

@cameronperera cameronperera merged commit a961b5e into main Nov 19, 2024
12 checks passed
@cameronperera cameronperera deleted the fix/fast-sourcemap-concat branch November 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants