Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node engines to work with node 20 and 22 #2486

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrade node engines to work with node 20 and 22 #2486

wants to merge 5 commits into from

Conversation

calcaide
Copy link
Collaborator

@calcaide calcaide commented Sep 12, 2024 •
edited
Loading

Description

Upgrade node engines to work with node 20 and 22.

@calcaide calcaide self-assigned this Sep 12, 2024
@calcaide calcaide requested a review from a team as a code owner September 12, 2024 20:58
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ❌ Failed (Inspect) Nov 20, 2024 11:00pm
boundary-ui-desktop ❌ Failed (Inspect) Nov 20, 2024 11:00pm

@cameronperera
Copy link
Collaborator

Since node 21 is already past it's maintenance window, should we try going straight to v22 instead?

@DhariniJeeva
Copy link
Collaborator

should we also consider using the same version in boundary-ui-releases?

@calcaide
Copy link
Collaborator Author

@cameronperera

Good point.

Some thinking loud:

  • Right now 20 is LTS, so we should keep node 20 support IMHO.
  • As you mention 22 is current.
  • So we should keep support for: 20 and 22.

is that correct?

@cameronperera
Copy link
Collaborator

@cameronperera

Good point.

Some thinking loud:

  • Right now 20 is LTS, so we should keep node 20 support IMHO.
  • As you mention 22 is current.
  • So we should keep support for: 20 and 22.

is that correct?

Correct. If we are going to upgrade our supported node version, we should probably stick to the LTS versions. Plus v22 doesn't start it's maintenance schedule until a year from now. So this should hold us for a while.

@calcaide
Copy link
Collaborator Author

@cameronperera

Awesome!! pushing changes 😃

@calcaide
Copy link
Collaborator Author

@DhariniJeeva

We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while.
Something I will like to explore once TS is released.

Thoughts?

@DhariniJeeva
Copy link
Collaborator

@DhariniJeeva

We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while. Something I will like to explore once TS is released.

Thoughts?

that sounds good!

@calcaide
Copy link
Collaborator Author

@DhariniJeeva
Due to reverting the node20 upgrade changes within boundary-ui-releases I will hold this PR until we can run node20 within the pipeline.

@calcaide calcaide changed the title Upgrade node engines to work with node 20 and 21 Upgrade node engines to work with node 20 and 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisbet-alvarez lisbet-alvarez lisbet-alvarez approved these changes

@cameronperera cameronperera cameronperera approved these changes

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

Assignees

@calcaide calcaide

Labels
addons admin api-addon auth-addon desktop styles-addon ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calcaide @cameronperera @DhariniJeeva @lisbet-alvarez