Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wait for FREEZE_COMPLETE before waiting on stream files #16663

Open
wants to merge 6 commits into
base: 13764-D-flush-nodecache-on-snapshots
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj requested review from a team as code owners November 19, 2024 13:34
@tinker-michaelj tinker-michaelj added this to the v0.57 milestone Nov 19, 2024
@tinker-michaelj tinker-michaelj self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (52cef7a) to head (b589c48).
Report is 156 commits behind head on 13764-D-flush-nodecache-on-snapshots.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                             @@
##             13764-D-flush-nodecache-on-snapshots   #16663      +/-   ##
==========================================================================
+ Coverage                                   57.91%   63.24%   +5.33%     
- Complexity                                  19690    20159     +469     
==========================================================================
  Files                                        2721     2539     -182     
  Lines                                       99517    94185    -5332     
  Branches                                    10293     9855     -438     
==========================================================================
+ Hits                                        57631    59566    +1935     
+ Misses                                      38291    31030    -7261     
+ Partials                                     3595     3589       -6     

see 763 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features:

Copy link

codacy-production bot commented Nov 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6eff73a1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6eff73a) Report Missing Report Missing Report Missing
Head commit (b589c48) 97004 63017 64.96%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16663) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Signed-off-by: Michael Tinker <[email protected]>
…hots' into explicitly-freeze-before-stream-validation
Signed-off-by: Michael Tinker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants