chore: merkle-testfixtures added #10135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Ebbers <[email protected]>
Signed-off-by: Hendrik Ebbers <[email protected]>
Signed-off-by: Hendrik Ebbers <[email protected]>
hendrikebbers
requested review from
tomzhenghedera,
nathanklick,
poulok,
timo0,
artemananiev and
OlegMazurov
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10135 +/- ##
==========================================
Coverage ? 63.28%
Complexity ? 30740
==========================================
Files ? 3333
Lines ? 134512
Branches ? 14021
==========================================
Hits ? 85132
Misses ? 46031
Partials ? 3349 ☔ View full report in Codecov by Sentry. |
imalygin
previously approved these changes
Nov 28, 2023
timo0
previously approved these changes
Nov 28, 2023
...gic/project-plugins/src/main/kotlin/com.hedera.hashgraph.jpms-module-dependencies.gradle.kts
Outdated
Show resolved
Hide resolved
lpetrovic05
previously approved these changes
Nov 29, 2023
hendrikebbers
changed the title
jeromy-cannon
previously approved these changes
Dec 4, 2023
hendrikebbers
changed the title
# Conflicts: # build-logic/project-plugins/src/main/kotlin/com.hedera.hashgraph.jpms-module-dependencies.gradle.kts # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/merkle/map/FCMTransactionHandler.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/merkle/map/FCMTransactionPool.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/merkle/map/FCMTransactionUtils.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/merkle/map/internal/ExpectedFCMFamilyImpl.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/merkle/map/internal/ExpectedMapUtils.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/FCMQueryController.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolMain.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/nft/NftSimpleQuerier.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/stream/AccountBalanceExport.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/virtualmerkle/transaction/handler/VirtualMerkleTransactionHandler.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/test/java/com/swirlds/demo/merkle/map/internal/ExpectedFCMFamilyTest.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/test/java/com/swirlds/demo/platform/PttTransactionPoolTest.java # platform-sdk/swirlds-unit-tests/structures/swirlds-merkle-test/src/main/java/module-info.java
Signed-off-by: Hendrik Ebbers <[email protected]>
hendrikebbers
dismissed stale reviews from jeromy-cannon, lpetrovic05, timo0, and imalygin
via
3956756
jeromy-cannon
approved these changes
Dec 15, 2023
hendrikebbers
requested review from
jjohannes,
imalygin,
timo0 and
lpetrovic05
imalygin
reviewed
Dec 15, 2023
| @@ -160,7 +157,9 @@ public static List<MapKey> getMapKeys(final FCMTransaction fcmTransaction) { | |||
| } | |||
|
|
|||
| private static boolean isBodyRelatedToNft(final Object body) { | |||
| return body instanceof TransferToken || body instanceof BurnToken || body instanceof MintToken; | |||
| return body instanceof com.swirlds.demo.platform.fs.stresstest.proto.TransferToken | |||
There was a problem hiding this comment.
is there reason for using fully-qualified names here?
imalygin
approved these changes
Dec 15, 2023
cody-littley
approved these changes
Dec 15, 2023
jjohannes
approved these changes
Dec 15, 2023
lpetrovic05
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding testFixtures source set to merkle module
Part of #7168