Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the great protocol refactor #90

Open
wants to merge 68 commits into
base: main
Choose a base branch
from
Open

the great protocol refactor #90

wants to merge 68 commits into from

Conversation

yusdacra
Copy link
Member

@yusdacra yusdacra commented Feb 3, 2022 •
edited
Loading

Resolves #84
Resolves #92
Resolves #93
Resolves #94
Resolves #96

Voice is completely changed (now called webrtc service).

things that will need migration

  • chat.v1.Guild
    • guild kind was removed
  • chat.v1.Message
    • Content changes
      • Embed changes
      • Attachment changes
      • Reaction changes
  • profile.v1.Profile
    • UserStatus changes

@yusdacra yusdacra added the enhancement New feature or request label Feb 3, 2022
@yusdacra yusdacra changed the title feat(chat): add invite created / deleted / used events feat: add invite created / deleted / used events, documentation Feb 6, 2022
@yusdacra yusdacra mentioned this pull request Feb 6, 2022
Closed
4 tasks
@yusdacra yusdacra requested review from pontaoski and bluskript and removed request for pontaoski February 6, 2022 01:51
bluskript
bluskript reviewed Feb 7, 2022
View reviewed changes
stable/chat/v1/messages.proto Outdated Show resolved Hide resolved
stable/emote/v1/types.proto Outdated Show resolved Hide resolved
@yusdacra yusdacra changed the title feat: add invite created / deleted / used events, documentation the great protocol refactor Feb 11, 2022
bluskript
bluskript approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@bluskript bluskript left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solves a lot of technical debt issues and protocol limitations we were facing in the older versions, good work!

@pontaoski
Copy link
Member

this is a severely breaking change; we agreed not to do these

@pontaoski pontaoski closed this Feb 11, 2022
yusdacra and others added 30 commits April 2, 2022 04:08
@yusdacra
feat: bot tokens (#99)
9c39c99 
Co-authored-by: spiral <[email protected]>
@yusdacra
feat: separate private channels from guilds (#100)
94b1112 
Co-authored-by: spiral <[email protected]>
@yusdacra
feat: refactor actions (#101)
d9f35a3 
Co-authored-by: spiral <[email protected]>
@yusdacra
fix(chat): message name typo
ac35c01
@yusdacra
fix(chat): add missing get private channel list rpc
6ad5b1d
@yusdacra
fix(chat): remove unused import
a2d4082
@yusdacra
fix(chat): fix a few fields that need to be optional
90a1fc0
@yusdacra
fix(chat): typing request should have an optional guild id
ffb8ca8
@yusdacra
fix: fix location.guild_invite_id to be string, remove invite_id from…
6bbbadc 
… UserRejectedInvite, add location to PendingInvite
@yusdacra
fix: Invite* events should also use location
f424aa0
@yusdacra
feat(chat): add GetOutgoingPendingInvites to let users fetch the invi…
63b855f 
…tes they have sent that haven't been rejected
@yusdacra
feat(chat): add DeleteOutgoingInvite to delete and cancel an outgoing…
fb9028f 
… invite
@yusdacra
fix(chat): Reject/Ignore pending invite requests should use PendingIn…
14be6dd 
…vite
@yusdacra
feat(chat): allow specifying pack_id optionally in Emoji format
cc41fa8
@yusdacra
refactor(chat): Invite* events should use Pending/Outgoing Invite
abd8124
@yusdacra
refactor(chat): make more server_ids optional
317b784
@yusdacra
feat(sync): add inviter_id to user rejected invite
848b617
@yusdacra
feat: remove outgoing invites, add join private channel
c964791
@yusdacra
fix(chat): remove outgoing invite usage
724cf95
@yusdacra
fix(chat): add field names
0981d97
@yusdacra
refactor(chat): make pending invite endpoints not use pending invite …
87a9359 
…object
@yusdacra
docs(chat): document when a pending invite is unique
ca3ebac
@yusdacra
feat(chat): add leave private channel endpoint
db38966
@yusdacra
refactor(chat): rename is_locked to is_dm, let create private channel…
64ea59e 
… join the user to dm if already joined before
@yusdacra
refactor(chat): make another server id optional
772798b
@bluskript
add private channel data to get rpc, add optional name
b265a91
@bluskript
separate private channel fetching and its data
b47c27f
@yusdacra
refactor(chat): GetPrivateChannelData -> GetPrivateChannel
598e413
@yusdacra
refactor(chat): dont use optional name in UpdatePrivateChannelNameReq…
e438b77 
…uest
@yusdacra
feat(chat): consolidate UpdatePrivateChannel\* RPCs into one, add Pri…
a1319c7 
…vateChannelUpdated stream event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pontaoski pontaoski pontaoski requested changes

@bluskript bluskript bluskript approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@yusdacra @pontaoski @bluskript