Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement TRCWriter feature for v1.1 #1702

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hiteshhedwig
Copy link

current TRCWriter does not implement method for fileversion 1.1. So i have implemented it. And trc can be generated as follows

;$FILEVERSION=1.1
;$STARTTIME=45248.7383051968
;
;   Start time: 18-11-2023 17:43:09.569.0
;   Generated by PCAN-View v5.0.1.822
;
;   Message Number
;   |         Time Offset (ms)
;   |         |        Type
;   |         |        |        ID (hex)
;   |         |        |        |     Data Length
;   |         |        |        |     |   Data Bytes (hex) ...
;   |         |        |        |     |   |
;---+--   ----+----  --+--  ----+---  +  -+ -- -- -- -- -- -- --
     1)         2.6  Rx         0020  8  80 00 A0 06 68 03 3A 00 
     2)         3.2  Rx     18DAF101  8  10 18 62 02 2F 81 90 02 
     3)         4.7  Rx     18DA01F1  8  30 0A 0A 55 55 55 55 55 
     4)        11.7  Rx     0C0AA7F0  8  00 00 00 00 00 00 00 00 

Please feel free to leave any feedback

@zariiii9003
Copy link
Collaborator

@hiteshhedwig I rebased and fixed the mypy issues. You should include the new parameter in the docstring and add some test.

@pierreluctg pierreluctg added the file-io about reading & writing to files label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-io about reading & writing to files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants