Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inefficiencies, causes write delays to drop #1572

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

silverv
Copy link

@silverv silverv commented Apr 21, 2023

Did some experiments and measurements to conclude that these changes introduce less write delay. It is also likely that CPU load will be decreased with these changes.

@silverv
Copy link
Author

silverv commented Apr 21, 2023

On Windows it is important to note that a REALTIME priority level can be assigned to the process.

@silverv
Copy link
Author

silverv commented Apr 21, 2023

This is a continuation of #1490

@silverv
Copy link
Author

silverv commented Apr 21, 2023

I am doing this to improve the performance of SLCAN in Yakut (https://github.com/OpenCyphal/yakut) and Yukon (https://github.com/OpenCyphal/yukon).

@zariiii9003
Copy link
Collaborator

With your changes the timeout parameter will do nothing.
Also, your title mentions write delays, but you change the read function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants