Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing canonical search #6105

Merged
merged 4 commits into from
Jul 15, 2024
Merged

fixing canonical search #6105

merged 4 commits into from
Jul 15, 2024

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Jul 12, 2024

closes #6094

Copy link

Formatting check succeeded!

Copy link
Collaborator

@codeforgreen codeforgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good.
Please check my comment. Also I believe FhirResourceDaoR4SearchIncludeTest.testIncludeCanonicalReference needs to update updated.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (497b9f2) to head (faf0da7).
Report is 142 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6105      +/-   ##
============================================
+ Coverage     83.39%   83.53%   +0.14%     
- Complexity    26927    27422     +495     
============================================
  Files          1681     1706      +25     
  Lines        103965   106177    +2212     
  Branches      13189    13396     +207     
============================================
+ Hits          86702    88699    +1997     
- Misses        11613    11748     +135     
- Partials       5650     5730      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TipzCM TipzCM merged commit 875b224 into master Jul 15, 2024
65 of 66 checks passed
@TipzCM TipzCM deleted the 6094-fixing-canonical-search branch July 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioned canonical reference sort is broken
2 participants