Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Bucketed Item Tracker(s) Improvements #2987

Open
wants to merge 24 commits into
base: beta
Choose a base branch
from

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Nov 25, 2024

Dependencies

What

An actually functional version following up from #2582
This came up again today as I'm gonna start looking into making the Pest Tracker bucketed as well.

Also converts the Pest Profit Tracker to a BucketedItemTracker, so that moving forward, gains will be tracked by pest type.
A lot of the work there was in getting the data to be lossless and trying to map it over.

Images

image

image

image

Changelog Improvements

  • Mineshaft Corpse Tracker now supports /shedittracker. - Daveed
  • Pest Profit Tracker now supports filtering by Pest Type. - Daveed
    • Best effort was made in mapping existing data, however Coins, and common items may be mis-attributed or missing from individual pests.
  • Pest Profit Tracker will now correctly track quantity of rare drops from pests. - Daveed
    • E.g., Enchanted Mushroom Blocks from slugs will now count 15 instead of 1.

@github-actions github-actions bot added the Detekt Has detekt problem label Nov 25, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 25, 2024
@DavidArthurCole DavidArthurCole changed the title Improvement: /shedittracker with Bucketed Item Tracker(s) Improvement: Bucketed Item Tracker(s) Improvements Nov 30, 2024
@github-actions github-actions bot added the Detekt Has detekt problem label Nov 30, 2024
Copy link

One or more Detekt Failures were detected:

  • BucketedItemTrackerData.kt#L88: Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided.

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 30, 2024
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

I have detected some issues with your pull request:

Body issues:
Unknown line after changes started being declared in text: + Pest Profit Tracker will now correctly track quantity of rare drops from pests. - Daveed

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants