-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Bucketed Item Tracker(s) Improvements #2987
Open
DavidArthurCole
wants to merge
24
commits into
hannibal002:beta
Choose a base branch
from
DavidArthurCole:BucketTrackerAddItem
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improvement: Bucketed Item Tracker(s) Improvements #2987
DavidArthurCole
wants to merge
24
commits into
hannibal002:beta
from
DavidArthurCole:BucketTrackerAddItem
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more Detekt Failures were detected:
|
DavidArthurCole
changed the title
Improvement:
Improvement: Bucketed Item Tracker(s) Improvements
Nov 30, 2024
/shedittracker
with Bucketed Item Tracker(s)
One or more Detekt Failures were detected:
|
github-actions
bot
added
the
Wrong Title/Changelog
There is an error in the title or changelog
label
Dec 2, 2024
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
There is an error in the title or changelog
label
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
An actually functional version following up from #2582
This came up again today as I'm gonna start looking into making the Pest Tracker bucketed as well.
Also converts the Pest Profit Tracker to a
BucketedItemTracker
, so that moving forward, gains will be tracked by pest type.A lot of the work there was in getting the data to be lossless and trying to map it over.
Images
Changelog Improvements
/shedittracker
. - Daveed