-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Hoppity Live Display Date/Time #2973
Open
DavidArthurCole
wants to merge
8
commits into
hannibal002:beta
Choose a base branch
from
DavidArthurCole:HoppityGuiDateTime
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Hoppity Live Display Date/Time #2973
DavidArthurCole
wants to merge
8
commits into
hannibal002:beta
from
DavidArthurCole:HoppityGuiDateTime
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
hannibal002
added
the
Soon
This Pull Request will be merged within the next couple of betas
label
Nov 23, 2024
github-actions
bot
added
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Nov 24, 2024
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Nov 24, 2024
Conflicts have been resolved! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a toggleable and formattable date/time display to Hoppity Live Event cards, that can be configured to show for Past/Current/Future events separately.
Also did some technical cleanup of some of the Date/Time logic that the hoppity codebase was relying on.
Images
Changelog New Features