-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tcpdi_parser to package #71
Open
vitormattos
wants to merge
8
commits into
hanneskod:master
Choose a base branch
from
LibreSign:move-tcpdi-parser-to-package
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move tcpdi_parser to package #71
vitormattos
wants to merge
8
commits into
hanneskod:master
from
LibreSign:move-tcpdi-parser-to-package
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
changed the title
Move tcpdi parser to package
Move tcpdi_parser to package
Jan 31, 2022
Hi @hanneskod can you help to check if all is ok on this PR? |
Hi, Any updates on this? |
I'm follow using my fork |
Looking at code I remembered that I stopped to use this package after a lot of problems on scenario that I need to use merging PDF from different sources. I started to use mikehaertl/php-pdftk and this solved all problems about merge PDF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review first #69
Close #64
I merged all fixes to
tcpdi_parser
on this PR and the changes of libmergepdf ontcpdi_parser
too.