Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported tracing exporters in README.md and fix typo in flag description #233

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update supported tracing exporters in README.md and fix typo in flag description #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5364952
Update README.md
Ullaakut Oct 3, 2023
a8e06aa
Update trace.go
Ullaakut Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ The tracing flags are used by `cmd.NewTracer` to create a new open telemetry `tr

#### FlagTracingExporter: *--tracing.exporter, $TRACING_EXPORTER*

This flag sets the exporter to send spans to. The available options are `jaeger` and `zipkin`.
This flag sets the exporter to send spans to. The available options are `zipkin`, `otlphttp` and `otlpgrpc`.

Example: `--tracing.exporter=jaeger`

Expand Down
2 changes: 1 addition & 1 deletion trace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const (
var TracingFlags = Flags{
&cli.StringFlag{
Name: FlagTracingExporter,
Usage: "The tracing backend. Supported: 'zipkin', 'otlphttp', 'otlpgrpc.",
Usage: "The tracing backend. Supported: 'zipkin', 'otlphttp', 'otlpgrpc'.",
EnvVars: []string{"TRACING_EXPORTER"},
},
&cli.StringFlag{
Expand Down
Loading