Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add observer package #230

Merged
merged 2 commits into from
Oct 2, 2023
Merged

feat: add observer package #230

merged 2 commits into from
Oct 2, 2023

Conversation

Ullaakut
Copy link
Contributor

@Ullaakut Ullaakut commented Oct 2, 2023 •
edited
Loading

Goal of this PR

This PR adds the observe package to the cmd project, and updates the README accordingly with an example of how one might use it.

How to test it

  • It compiles
  • Tests pass
  • README changes make sense and are complete

nrwiersma
nrwiersma approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nrwiersma nrwiersma merged commit 4c16c77 into hamba:main Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrwiersma nrwiersma nrwiersma approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ullaakut @nrwiersma