Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFP-3852 Fix number field validation #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Jan 6, 2024

When merged in, will fix the validate function of a number field to return true if the field is optional and nothing is set.

Currently, the validate function returns undefined if the field is optional and not value is set. One can work around this, of course, but it feels unintuitive if the return value is a boolean for when the value does not validate but undefined if it validates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant