Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more DANE lookups for internal handler pages #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

techhazard
Copy link
Contributor

@techhazard techhazard commented Mar 10, 2017

The proxy used to try and connect to some internal addresses (but not
others)

This makes it explicit that the eccaProxy function will handle
everything but "ecca.handler" requests which will result in no more
DANE lookups for internal pages which, in turn, will result in no more
errors in the log about unavailable DANE records.

The proxy used to try and connect to some internal addresses (but not
others)

This makes it explicit that the `eccaProxy` function will handle
everything *but* `"ecca.handler"` requests which will result in no more
DANE lookups for internal pages which, in turn, will result in no more
errors in the log about unavailable DANE records.
@gwitmond
Copy link
Owner

Regrettable, in my environment, this gives a worse error than the missing dane record you want to avoid. To reproduce: install this PR, close your browser, reopen and navigate to ecca.handler/manage. Boom.

2017/03/11 21:21:17 http: panic serving 127.0.0.1:41281: runtime error: invalid memory address or nil pointer dereference
goroutine 12 [running]:
net/http.(*conn).serve.func1(0xc8203ba800)
        /usr/lib/go-1.6/src/net/http/server.go:1389 +0xc1
panic(0x9567e0, 0xc82000e140)
        /usr/lib/go-1.6/src/runtime/panic.go:443 +0x4e9
main.DecodeMessages(0x0, 0xc820359cc0, 0x422201)
        /home/guido/gopath/src/github.com/gwitmond/ecca-proxy/proxy.go:457 +0x45

@techhazard
Copy link
Contributor Author

I see, I'll look into another way of mitigating this.

@techhazard
Copy link
Contributor Author

Would you still like to merge this? Because then I'll look into it.
Otherwise I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants