[WIP] feat(Azure): add new check for private DNS zones #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
reviewed
Oct 22, 2024
modules/azure/privatednszone.go
Outdated
|
|
||
| // PrivateDNSZoneExists indicates whether the specified private DNS zone exists. | ||
| // This function would fail the test if there is an error. | ||
| func PrivateDNSZoneExists(t *testing.T, zoneName string, resourceGroupName string, subscriptionID string) bool { |
There was a problem hiding this comment.
Unused function 'PrivateDNSZoneExists'
modules/azure/privatednszone.go
Outdated
|
|
||
| // GetPrivateDNSZone gets the private DNS zone object | ||
| // This function would fail the test if there is an error. | ||
| func GetPrivateDNSZone(t *testing.T, zoneName string, resGroupName string, subscriptionID string) *privatedns.PrivateZone { |
There was a problem hiding this comment.
Unused function GetPrivateDNSZone
modules/azure/client_factory.go
Outdated
| // CreatePrivateDnsZonesClientE is a helper function that will setup a private DNS zone client. | ||
| func CreatePrivateDnsZonesClientE(subscriptionID string) (*privatedns.PrivateZonesClient, error) { | ||
| // Validate Azure subscription ID | ||
| subscriptionID, err := getTargetAzureSubscription(subscriptionID) |
There was a problem hiding this comment.
I would suggest changing subscriptionID to different name to avoid shadowing
|
@denis256 I have implemented your comments, please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds #1454 .
This PR adds an assertion helper for Azure Private DNS Zones.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added support for Azure Private DNS Zones assertion helpers.