Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional args to init command #1259

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dnitsch
Copy link

@dnitsch dnitsch commented Mar 6, 2023

Description

Expose additional args to init command, maintaining old behaviour of allowing existing properties to certain configurations.

Fixes #318.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

ensure existing properties specifically called out are "protected"

addressess gruntwork-io#318
Not doing an InitApply so never writes it out

 tested previously
should avoid untested errors when run in Parallel
@@ -71,6 +71,8 @@ type Options struct {
PlanFilePath string // The path to output a plan file to (for the plan command) or read one from (for the apply command)
PluginDir string // The path of downloaded plugins to pass to the terraform init command (-plugin-dir)
SetVarsAfterVarFiles bool // Pass -var options after -var-file options to Terraform commands
AdditionalInitFlags []string // additional flags to pass to init command - e.g. `-backend=false`. complete list of options [here](https://developer.hashicorp.com/terraform/cli/commands/init)
// AdditionalApplyDestroylags []string // additional flags to pass to apply/destroy command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdditionalApplyDestroylags is required? - looks like it is commented and not referenced

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct ... can be deleted.

@sjcarrillo
Copy link

sjcarrillo commented Sep 6, 2023

Do we know if this will get worked on further?
Am looking forward to having this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Question) Can we specify backend=false
3 participants