Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the multiple server-side requests bug #1408

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Conversation

afshinm
Copy link
Member

@afshinm afshinm commented Dec 30, 2023

Fixes #1356
Fixes #1330
Fixes #1317

Copy link

github-actions bot commented Dec 31, 2023

Size Change: +724 B (+1%)

Total Size: 94.5 kB

Filename Size Change
dist/gridjs.js 16.4 kB +148 B (+1%)
dist/gridjs.module.js 16.4 kB +149 B (+1%)
dist/gridjs.production.es.min.js 16.4 kB +149 B (+1%)
dist/gridjs.production.min.js 16.4 kB +139 B (+1%)
dist/gridjs.umd.js 16.4 kB +139 B (+1%)
ℹ️ View Unchanged
Filename Size
l10n/dist/l10n.js 3.05 kB
l10n/dist/l10n.module.js 3.13 kB
l10n/dist/l10n.umd.js 3.18 kB
plugins/selection/dist/selection.js 1.05 kB
plugins/selection/dist/selection.module.js 1.07 kB
plugins/selection/dist/selection.umd.js 1.15 kB

compressed-size-action

Copy link

github-actions bot commented Jan 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
81.11% (+1.15% 🔼)
1331/1641
🟡 Branches
67.68% (+1.01% 🔼)
356/526
🟢 Functions
82.13% (+1.08% 🔼)
285/347
🟢 Lines
80.72% (+1.09% 🔼)
1172/1452
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 util/deepEqual.ts 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / pipeline.ts
96.33% (-0.64% 🔻)
92.31% (-3.34% 🔻)
100%
95.83% (-0.68% 🔻)
🟡
... / pagination.tsx
80% (-1.01% 🔻)
62.22% 55.56%
77.61% (-1.18% 🔻)

Test suite run success

185 tests passing in 33 suites.

Report generated by 🧪jest coverage report action from da64c76

@afshinm afshinm merged commit 4219ea6 into master Jan 9, 2024
5 checks passed
@afshinm afshinm deleted the fix-multiple-reqs branch January 9, 2024 09:12
@vkresch
Copy link

vkresch commented Jan 14, 2024

Many thanks for the fix! When would be an official release ready to use it?

@afshinm
Copy link
Member Author

afshinm commented Jan 14, 2024

@vkresch I will release a new version today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something isn't working
Projects
None yet
2 participants