Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exposing (..) for imports #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evuez
Copy link

@evuez evuez commented Aug 7, 2022

Fixes #76

@robinheghan is the goal to also remove internal usage of import ... exposing (..)? Seems like this is used for Basics.

@robinheghan
Copy link
Member

Thank you for looking into this, @evuez !

The compiler still needs to say that everything from Basics is imported, as I don't want there to be a tighter integration between the core package and the compiler than what we've already got.

Because it will still be possible to expose everything from a module definition, there should be a good error message for when people want to import everything, would you like to take a stab at that error message as part of this PR?

I mostly work on Gren at fridays, so I won't do a code review or merge the PR until then, just so you know.

Thanks again for looking into this 🙏

@robinheghan
Copy link
Member

@evuez I think your current approach looks good. :)

@evuez
Copy link
Author

evuez commented Aug 20, 2022

@robinheghan Sorry didn't have time to look more into that, was hoping to take a stab at the error message next week.

@robinheghan
Copy link
Member

@evuez Just to let you know, I'm starting to focus on bug-fixes and documentation improvements in about a week. So if you want this to land in time for 0.2, you're starting to run out of time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for «exposing (..)» from import statements
2 participants