Extend validator only when it is actually resolved #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid potential conflicts, it is better to extend the Laravel validator only when the IoC container is resolving it. Some issues may occur for example when you extend the validator with another package too. In my case, my acceptance tests failed because of this problem. By the way thanks for this very helpful package! :)
matthewnessworthy
added a commit
to RingierIMU/recaptcha
that referenced
this pull request
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid potential conflicts, it is better to extend the Laravel validator only when the IoC container is resolving it.
Some issues may occur for example when you extend the validator with another package too.
In my case, my acceptance tests failed because of this problem.
By the way thanks for this very helpful package! :)