Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix an issue which produces an interrupted scan, originated on a wrong count of excluded hosts. #1509

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jjnicola
Copy link
Member

What:
Fix: fix an issue which produces an interrupted scan, originated on a wrong count of excluded hosts.
Although there is no breaking changes, this fix depends on greenbone/gvm-libs#797

Jira: SC-929

Why:
Since excluded hosts are handled in OSPD, we need to keep the total host count which includes the hosts which will be excluded later

How:

  • Create a target with many alive hosts, someone with dns name
  • Exclude a host which doesn't have a name
  • Allow simultaneous scanning via multiple IPs: Yes
  • Port List All IANA assigned TCP
  • Alive Test Scan Config Default
  • No Credentials
  • Reverse Lookup Only : Yes
  • Reverse Lookup Unify : no
  • Create a task that is using the target and the scan config Host Discovery
  • Starting this task should interrupt the task at some percentage.

without the patch, the scan is interrupted. With the patch the scan finishes successfully.
Try other targets and configurations.

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola requested a review from a team as a code owner October 10, 2023 12:50
@jjnicola jjnicola added the patch_release creates a patch release label Oct 10, 2023
@jjnicola jjnicola marked this pull request as draft October 10, 2023 13:17
@jjnicola jjnicola marked this pull request as ready for review October 10, 2023 13:27
src/attack.c Outdated Show resolved Hide resolved
… wrong count of excluded hosts.

Since excluded hosts are handled in OSPD, we need to keep the total host count which includes the hosts which will be excluded later
@jjnicola jjnicola merged commit 9542a1c into main Oct 11, 2023
28 checks passed
@jjnicola jjnicola deleted the reverse-lookup branch October 11, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch_release creates a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants