Add warning status to mattermost-notify action

greenbone · Nov 12, 2024 · d6eff54 · d6eff54
1 parent e9dd003
commit d6eff54
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 2 deletions.
diff --git a/mattermost_notify/git.py b/mattermost_notify/git.py
@@ -116,7 +116,7 @@ def fill_template(
             commit_message = head_commit.get("message", "").split("\n", 1)[0]
 
     highlight_str = ""
-    if highlight and workflow_status is not Status.SUCCESS:
+    if highlight and workflow_status not in (Status.SUCCESS, Status.WARNING):
         highlight_str = "".join([f"@{h}\n" for h in highlight])
 
     return template.format(

diff --git a/mattermost_notify/parser.py b/mattermost_notify/parser.py
@@ -33,7 +33,7 @@ def parse_args(args=None) -> Namespace:
         "-S",
         "--status",
         type=str,
-        choices=["success", "failure"],
+        choices=["success", "failure", "warning"],
         default=Status.SUCCESS.name,
         help="Status of Job",
     )

diff --git a/mattermost_notify/status.py b/mattermost_notify/status.py
@@ -10,6 +10,7 @@ class Status(Enum):
     FAILURE = ":x: failure"
     UNKNOWN = ":grey_question: unknown"
     CANCELLED = ":no_entry_sign: canceled"
+    WARNING = ":warning: warning"
 
     def __str__(self):
         return self.name
diff --git a/tests/test_git.py b/tests/test_git.py
@@ -34,6 +34,21 @@ def test_success_no_highlight(self):
 | Repository (branch) |  ([](/tree/)) |
 | Related commit | [](/commit/) |
 
+"""
+        self.assertEqual(expected, actual)
+
+    def test_warning_no_highlight(self):
+        actual = fill_template(
+            highlight=["user1", "user2"],
+            status=Status.WARNING.name,
+        )
+        expected = """#### Status: :warning: warning
+
+| Workflow |  |
+| --- | --- |
+| Repository (branch) |  ([](/tree/)) |
+| Related commit | [](/commit/) |
+
 """
         self.assertEqual(expected, actual)
 

diff --git a/tests/test_parser.py b/tests/test_parser.py
@@ -39,6 +39,17 @@ def test_parse_status(self):
         )
         self.assertEqual(parsed_args.status, "failure")
 
+    def test_parse_warning_status(self):
+        parsed_args = parse_args(
+            [
+                "www.url.de",
+                "channel",
+                "-S",
+                "warning",
+            ]
+        )
+        self.assertEqual(parsed_args.status, "warning")
+
     def test_parse_short(self):
         parsed_args = parse_args(
             [