Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old variable #2220

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Remove old variable #2220

merged 1 commit into from
Jun 14, 2024

Conversation

mattmundell
Copy link
Contributor

What

Remove variable quoted_default from config_insert_preferences.

Why

Usage of this variable was removed in /pull/1694, see line 2393 in 52f3c3a.

Quick test

o m m '<create_config><copy>af240023-7111-40b5-9ed3-e8362a59238d</copy></create_config>'
o m m '<get_configs config_id="74a22450-45da-4639-9574-0e05792981a0" details="1"/>' > /tmp/cnew
o m m '<get_configs config_id="af240023-7111-40b5-9ed3-e8362a59238d" details="1"/>' > /tmp/cold
diff /tmp/cnew /tmp/cold # preferences should be the same

@mattmundell mattmundell requested a review from a team as a code owner June 11, 2024 10:30
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@a-h-abdelsalam a-h-abdelsalam merged commit a2cb9d0 into main Jun 14, 2024
11 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the remove-var branch June 14, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants