Fix: missing return in handle_get_credentials #2195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the GET_CREDENTIALS handler, add a
return
after the credential format error.Why
The
return
is required else gvmd sends the credentials after the error response.This format error can be invoked by calling GET_CREDENTIALS with an erroneous
format
attribute, for example:Here's the response before the PR (note the extra
get_credentials_response
element):Here's the response after the PR, with the single correct element: